-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug with offsetSections when used with scrollOverflow #2878
Comments
What do you mean by that? The section is taking the whole viewport as it should. Then creating the internal scroll bar. What's wrong there?
The top sections have so little content that no scrollable bar is created, even when i reduce the width of the viewport considerably. Can you please post a picture of it?
I'm in section 2 (Section set with 'data-percentage="80"') and I'm not able to reproduce that either. |
You can see the problem here; https://www.youtube.com/watch?v=eMdUs7BvO3c Here is what is happening in DOM causing the problem; I have replicated this on chrome, safari and firefox. |
Thanks for that, I was able to see what you mean now and to reproduce it on your fiddle. |
- Fixed bug: offsetSections not working when using paddingTop alvarotrigo#2876 - Fixed bug: continuousVertical not selecting proper navigation bullet alvarotrigo#2917
- Fixed bug: offsetSections not working when using paddingTop alvarotrigo#2876 - Fixed bug: continuousVertical not selecting proper navigation bullet alvarotrigo#2917
Description
With both offsetSections and scrollOverflow enabled, sections without scrollable content sometimes get the content wrapped in container ".fp-scrollable" and with height set - this is causing it to no longer be centered.
Link to isolated reproduction with no external CSS / JS
[Removed link]
Steps to reproduce it
Versions
Chrome 60 and Safari 10.1.2 on OSX
The text was updated successfully, but these errors were encountered: