Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with offsetSections when used with scrollOverflow #2878

Closed
omikron opened this issue Aug 31, 2017 · 3 comments
Closed

Bug with offsetSections when used with scrollOverflow #2878

omikron opened this issue Aug 31, 2017 · 3 comments

Comments

@omikron
Copy link

omikron commented Aug 31, 2017

Description

With both offsetSections and scrollOverflow enabled, sections without scrollable content sometimes get the content wrapped in container ".fp-scrollable" and with height set - this is causing it to no longer be centered.

Link to isolated reproduction with no external CSS / JS

[Removed link]

Steps to reproduce it

  1. Load link - usually content is loaded with the top sections already wrapped with .fp-scrollable causing them to not be centered vertically.
  2. Resize width of browser and when you stop resizing the content will go back and forth from center to top aligned.

Versions

Chrome 60 and Safari 10.1.2 on OSX

@alvarotrigo
Copy link
Owner

this is causing it to no longer be centered.

What do you mean by that? The section is taking the whole viewport as it should. Then creating the internal scroll bar. What's wrong there?

Load link - usually content is loaded with the top sections already wrapped with .fp-scrollable causing them to not be centered vertically.

The top sections have so little content that no scrollable bar is created, even when i reduce the width of the viewport considerably. Can you please post a picture of it?

Resize width of browser and when you stop resizing the content will go back and forth from center to top aligned.

I'm in section 2 (Section set with 'data-percentage="80"') and I'm not able to reproduce that either.
Please contact me with more codepen links if you need to.

@omikron
Copy link
Author

omikron commented Sep 1, 2017

You can see the problem here;

https://www.youtube.com/watch?v=eMdUs7BvO3c

Here is what is happening in DOM causing the problem;

https://youtu.be/fWdpmruXRcA

I have replicated this on chrome, safari and firefox.

@alvarotrigo
Copy link
Owner

Thanks for that, I was able to see what you mean now and to reproduce it on your fiddle.
I'll investigate it!

alvarotrigo added a commit that referenced this issue Oct 9, 2017
- Fixed bug: offsetSections not working when using paddingTop #2876
- Fixed bug: continuousVertical not selecting proper navigation bullet
#2917
fynncfchen pushed a commit to fynncfchen/fullPage.js that referenced this issue Oct 14, 2017
- Fixed bug: offsetSections not working when using paddingTop alvarotrigo#2876
- Fixed bug: continuousVertical not selecting proper navigation bullet
alvarotrigo#2917
fynncfchen pushed a commit to fynncfchen/fullPage.js that referenced this issue Oct 15, 2017
- Fixed bug: offsetSections not working when using paddingTop alvarotrigo#2876
- Fixed bug: continuousVertical not selecting proper navigation bullet
alvarotrigo#2917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants