Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with loopHorizontal:false and jquery.fullpage.extensions.min.js #2548

Closed
spaszwerg opened this issue Feb 6, 2017 · 7 comments
Closed

Comments

@spaszwerg
Copy link

spaszwerg commented Feb 6, 2017

Script seems to crash when using the extension file. JS-Console alerts: TypeError: t is undefined

Hi,
i´m creating a fullPage website for a customer. The site is intended to work with the extensions dragandmove and resetSlides in the end. So I included the extension library from the dist-folder instead of the normal one.

My js in the html-file looks like this:

<script src="js/jquery.min.js"></script> (v3.1.1.)
<script src="js/jquery.fullpage.extensions.min.js"></script>
<script>
            $(document).ready(function() {
                $('#fullpage').fullpage({
                    loopHorizontal: false,
                    navigation: true,
                    verticalCentered: false,
                    navigationTooltips: ['view1', 'view2', 'view3', 'view4', 'view5', 'view6'],
                    menu: '.mobileNavDropdown',
                    anchors:['view1', 'view2', 'view3', 'view4', 'view5', 'view6'],
                    normalScrollElements:'.noScroll'
                });
            });
        </script> 

Steps to reproduce it

fullPage is working as expected, but if I´m on the last slide of an horizontal row and swipe right/right arrow on keyboard, the script crashes giving a console error: "TypeError: t is undefined".
I thought that might be because I didn´t include the extensions in the beginning.
After my customer got these from your shop I included them, but no change. The script still stops working if I try to slide to the next slide, that doesn´t exist.

The problem disapperas when setting the loopHorizontal option to true, but thats not what the customer wants.

Versions

Tested on Win10 with FF51 and Chrome 56 as well as several Android smartphones.

Any hints or advices are welcome.

@alvarotrigo
Copy link
Owner

alvarotrigo commented Feb 6, 2017

fullPage is working as expected, but if I´m on the last slide of an horizontal row and swipe right/right arrow on keyboard, the script crashes giving a console error: "TypeError: t is undefined".

Are you saying you were having this error before using the extensions?
If so, can you please provide an isolated reproduction in jsfiddle or codepen with no external CSS and JS?

@spaszwerg
Copy link
Author

spaszwerg commented Feb 6, 2017

Thank you for the quick reply.
I created a fiddle here:
https://jsfiddle.net/schuetzmedia/ekr890vd/7/

Just go to Slide 2.3 and press the arrow-right on the keyboard. The slides are no longer working.

@alvarotrigo
Copy link
Owner

Thanks for it.
Solved in the dev branch and will get merged in the next release.

@spaszwerg
Copy link
Author

Hi, thats good to hear.
When will the next release be?
My deadline is close ;o)

@alvarotrigo
Copy link
Owner

When will the next release be?

Probably this week. But you can use the file in the dev version. It will solve your issue.

@spaszwerg
Copy link
Author

Perfect! Thanks a lot.

@alvarotrigo alvarotrigo changed the title Problem with jquery.fullpage.extensions.min.js Problem with loopHorizontal:false and jquery.fullpage.extensions.min.js Feb 6, 2017
@alvarotrigo
Copy link
Owner

Solved in the new release 2.9.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants