Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IScroll is undefined #2281

Closed
shynome opened this issue Sep 22, 2016 · 4 comments
Closed

IScroll is undefined #2281

shynome opened this issue Sep 22, 2016 · 4 comments

Comments

@shynome
Copy link

shynome commented Sep 22, 2016

when I use requirejs load fullpage & scrolloverflow , it appears.
But I can't found where fullpage require 'scrolloverflow' or other name to use it

@alvarotrigo
Copy link
Owner

alvarotrigo commented Sep 22, 2016

Duplicated of #2250

The problem when using require is that makes dependencies compulsory as far as I know.
And scrollOverflow shouldn't be compulsory.

It seems to be some kind of trick, but I didn't look at it very much to be honest.

I'll close the issue to keep a single open threat about it. (#2250)

Feel free to create a pull request to solve it.

@shynome
Copy link
Author

shynome commented Sep 23, 2016

Thanks

Álvaro notifications@github.com于2016年9月22日周四 下午5:06写道:

Duplicated of #2250
#2250

The problem when using require is that makes dependencies compulsory as
far as I know.
And scrollOverflow shouldn't be compulsory.

It seems to be some kind of trick
http://stackoverflow.com/questions/14164610/requirejs-optional-dependency,
but I didn't look at it very much to be honest.

I'll close the issue to keep a single open threat about it. (#2250
#2250)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2281 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQg4ywxMBzbiWb7aUH7STDqJ0KMQTJnQks5qskUSgaJpZM4KDlpd
.

@ghost
Copy link

ghost commented Dec 14, 2016

scrolloverflow is amd compatible and can be used with requirejs. But fullpage does wrong define definition for amd. it defines jquery as dependency but not scrolloverflow. Therefore it is unknown within define and factory. To fix this issue for amd the fullpage.js needs to be refactored therefore.

@alvarotrigo
Copy link
Owner

But fullpage does wrong define definition for amd. it defines jquery as dependency but not scrolloverflow.

If you read my previous answer you'll see why's that.

The problem when using require is that makes dependencies compulsory as far as I know.
And scrollOverflow shouldn't be compulsory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants