Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes: historical data with descending order + JSON output for full historical data #237

Merged
merged 2 commits into from
Feb 6, 2021
Merged

Bug fixes: historical data with descending order + JSON output for full historical data #237

merged 2 commits into from
Feb 6, 2021

Conversation

imad3v
Copy link

@imad3v imad3v commented Nov 4, 2020

This pull request fixes 2 bugs in the functions to get the historical data:

  1. When order='descending', the data is correctly ordered inside each date interval of 19 years but the date intervals are not ordered between them.
  2. When as_json=True, only the first date interval (of 19 years) is returned instead of the full history.

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #237 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   90.92%   90.97%   +0.04%     
==========================================
  Files          26       26              
  Lines        4902     4929      +27     
==========================================
+ Hits         4457     4484      +27     
  Misses        445      445              

@alvarobartt
Copy link
Owner

Hi @imad3v! Could you please share a simple Jupyter Notebook reproducing the error so that I can check its output to see the bugs? Thanks! 👍🏻

@alvarobartt alvarobartt self-assigned this Nov 5, 2020
@alvarobartt alvarobartt added the bug Something isn't working label Nov 5, 2020
@imad3v
Copy link
Author

imad3v commented Nov 5, 2020

Hi @imad3v! Could you please share a simple Jupyter Notebook reproducing the error so that I can check its output to see the bugs? Thanks! 👍🏻

Hi @alvarobartt, here is an example: https://github.com/imad3v/investpy/blob/notebook-example/notebooks/Investpy%20bug%20example.ipynb

By the way, thanks for the amazing library!

@alvarobartt
Copy link
Owner

Thank you @imad3v 🤗 I'll close this before Christmas! BTW happy holidays!

@alvarobartt alvarobartt merged commit 2ffb6f2 into alvarobartt:master Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants