Merge pull request #176 from alucryd/develop #200
alucrydAnnotations
30 warnings
|
useless use of `vec!`:
src/import_dats.rs#L539
warning: useless use of `vec!`
--> src/import_dats.rs:539:22
|
539 | &vec![
| ______________________^
540 | | game_xml.roms.iter().collect::<Vec<&RomXml>>(),
541 | | game_xml.disks.iter().collect::<Vec<&RomXml>>(),
542 | | ]
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
help: you can use an array directly
|
539 ~ &[game_xml.roms.iter().collect::<Vec<&RomXml>>(),
540 + game_xml.disks.iter().collect::<Vec<&RomXml>>()]
|
|
|
useless use of `vec!`:
src/import_dats.rs#L416
warning: useless use of `vec!`
--> src/import_dats.rs:416:18
|
416 | &vec![
| __________________^
417 | | game_xml.roms.iter().collect::<Vec<&RomXml>>(),
418 | | game_xml.disks.iter().collect::<Vec<&RomXml>>(),
419 | | ]
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `#[warn(clippy::useless_vec)]` on by default
help: you can use an array directly
|
416 ~ &[game_xml.roms.iter().collect::<Vec<&RomXml>>(),
417 + game_xml.disks.iter().collect::<Vec<&RomXml>>()]
|
|
|
methods called `as_*` usually take `self` by reference or `self` by mutable reference:
src/xdelta3.rs#L70
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/xdelta3.rs:70:18
|
70 | fn as_xdelta(self) -> SimpleResult<XdeltaRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods called `as_*` usually take `self` by reference or `self` by mutable reference:
src/nsz.rs#L184
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/nsz.rs:184:15
|
184 | fn as_nsz(self) -> SimpleResult<NszRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods called `as_*` usually take `self` by reference or `self` by mutable reference:
src/nsz.rs#L163
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/nsz.rs:163:15
|
163 | fn as_nsp(self) -> SimpleResult<NspRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods called `as_*` usually take `self` by reference or `self` by mutable reference:
src/maxcso.rs#L175
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/maxcso.rs:175:21
|
175 | async fn as_xso(self) -> SimpleResult<XsoRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods called `as_*` usually take `self` by reference or `self` by mutable reference:
src/flips.rs#L74
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/flips.rs:74:15
|
74 | fn as_xps(self) -> SimpleResult<XpsRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods called `as_*` usually take `self` by reference or `self` by mutable reference:
src/dolphin.rs#L183
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/dolphin.rs:183:15
|
183 | fn as_rvz(self) -> SimpleResult<RvzRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
this function has too many arguments (9/7):
src/create_dats.rs#L121
warning: this function has too many arguments (9/7)
--> src/create_dats.rs:121:1
|
121 | / pub async fn create_dat<P: AsRef<Path>, Q: AsRef<Path>>(
122 | | connection: &mut SqliteConnection,
123 | | progress_bar: &ProgressBar,
124 | | input_directory: P,
... |
130 | | url: Option<&String>,
131 | | ) -> SimpleResult<()> {
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
methods called `as_*` usually take `self` by reference or `self` by mutable reference:
src/common.rs#L446
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/common.rs:446:19
|
446 | fn as_cue_bin(self, bin_romfiles: Vec<CommonRomfile>) -> SimpleResult<CueBinRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods called `as_*` usually take `self` by reference or `self` by mutable reference:
src/common.rs#L409
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/common.rs:409:15
|
409 | fn as_iso(self) -> SimpleResult<IsoRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods called `as_*` usually take `self` by reference or `self` by mutable reference:
src/chdman.rs#L548
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/chdman.rs:548:33
|
548 | async fn as_chd_with_parent(self, parent_romfile: ChdRomfile) -> SimpleResult<ChdRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods called `as_*` usually take `self` by reference or `self` by mutable reference:
src/chdman.rs#L547
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/chdman.rs:547:21
|
547 | async fn as_chd(self) -> SimpleResult<ChdRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods called `as_*` usually take `self` by reference or `self` by mutable reference:
src/chdman.rs#L112
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/chdman.rs:112:22
|
112 | async fn as_rdsk(self) -> SimpleResult<RdskRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
|
|
methods called `as_*` usually take `self` by reference or `self` by mutable reference:
src/chdman.rs#L86
warning: methods called `as_*` usually take `self` by reference or `self` by mutable reference
--> src/chdman.rs:86:22
|
86 | async fn as_riff(self) -> SimpleResult<RiffRomfile>;
| ^^^^
|
= help: consider choosing a less ambiguous name
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
= note: `#[warn(clippy::wrong_self_convention)]` on by default
|
|
method `as_xdelta` is never used:
src/xdelta3.rs#L70
warning: method `as_xdelta` is never used
--> src/xdelta3.rs:70:8
|
69 | pub trait AsXdelta {
| -------- method in this trait
70 | fn as_xdelta(self) -> SimpleResult<XdeltaRomfile>;
| ^^^^^^^^^
|
|
field `romfile` is never read:
src/wit.rs#L19
warning: field `romfile` is never read
--> src/wit.rs:19:5
|
18 | pub struct WbfsRomfile {
| ----------- field in this struct
19 | romfile: CommonRomfile,
| ^^^^^^^
|
|
field `regions_hashes` is never read:
src/model.rs#L288
warning: field `regions_hashes` is never read
--> src/model.rs:288:9
|
280 | pub struct Irdfile {
| ------- field in this struct
...
288 | pub regions_hashes: Vec<String>,
| ^^^^^^^^^^^^^^
|
|
method `as_xps` is never used:
src/flips.rs#L74
warning: method `as_xps` is never used
--> src/flips.rs:74:8
|
73 | pub trait AsXps {
| ----- method in this trait
74 | fn as_xps(self) -> SimpleResult<XpsRomfile>;
| ^^^^^^
|
|
field `xps_type` is never read:
src/flips.rs#L22
warning: field `xps_type` is never read
--> src/flips.rs:22:9
|
20 | pub struct XpsRomfile {
| ---------- field in this struct
21 | pub romfile: CommonRomfile,
22 | pub xps_type: XpsType,
| ^^^^^^^^
|
|
function `update_patch` is never used:
src/database.rs#L2325
warning: function `update_patch` is never used
--> src/database.rs:2325:14
|
2325 | pub async fn update_patch(
| ^^^^^^^^^^^^
|
|
function `find_roms_with_romfile_by_system_id` is never used:
src/database.rs#L1154
warning: function `find_roms_with_romfile_by_system_id` is never used
--> src/database.rs:1154:14
|
1154 | pub async fn find_roms_with_romfile_by_system_id(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
function `find_roms` is never used:
src/database.rs#L1013
warning: function `find_roms` is never used
--> src/database.rs:1013:14
|
1013 | pub async fn find_roms(connection: &mut SqliteConnection) -> Vec<Rom> {
| ^^^^^^^^^
|
|
function `find_games` is never used:
src/database.rs#L595
warning: function `find_games` is never used
--> src/database.rs:595:14
|
595 | pub async fn find_games(connection: &mut SqliteConnection) -> Vec<Game> {
| ^^^^^^^^^^
|
|
field `size` is never read:
src/ctrtool.rs#L28
warning: field `size` is never read
--> src/ctrtool.rs:28:9
|
26 | pub struct ArchiveInfo {
| ----------- field in this struct
27 | pub path: String,
28 | pub size: u64,
| ^^^^
|
= note: `ArchiveInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|
|
method `patch` is never used:
src/common.rs#L38
warning: method `patch` is never used
--> src/common.rs:38:14
|
37 | pub trait PatchFile {
| --------- method in this trait
38 | async fn patch<P: AsRef<Path>>(
| ^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|