This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
BUG: make selenium saver respect chart theme #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still would like to figure out how to make the |
|
Well, I can also show the difference between figure save it "manually" and by saver. I think that such a huge difference is unintended. Should I open new issue topic for it? |
|
Sure, open an issue and show the difference. Note that the nodejs-based savers do not support themes, even after this PR is merged, and there does not appear to be any way to fix that issue at the moment due to a limitation in vega-cli. |
|
I'm going to merge this – it appears to correct the theme issue for selenium + png & svg. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #21