Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eio/home-hero #2782

Merged
merged 3 commits into from
Feb 26, 2025
Merged

Eio/home-hero #2782

merged 3 commits into from
Feb 26, 2025

Conversation

eioluseyi
Copy link
Contributor

@eioluseyi eioluseyi commented Feb 25, 2025

Fixes

Add an animated gradient text component fon the home hero

Checks

  • Ran yarn test-build
  • Updated relevant documentations
  • Updated matching config options in altair-static

Changes proposed in this pull request:

Add an animated gradient text component fon the home hero

Summary by Sourcery

New Features:

  • Added an animated gradient text component to the home hero section of the documentation site.

Copy link

sourcery-ai bot commented Feb 25, 2025

Reviewer's Guide by Sourcery

This pull request introduces an animated gradient text component to the home hero section, enhancing the visual appeal with a dynamic gradient effect and retro grid background. The AnimatedGradientText component is used to wrap the 'Discover Altair GraphQL Cloud' text, providing a visually engaging link.

Class diagram for AnimatedGradientText component

classDiagram
  class AnimatedGradientText {
    + gradient-background: linear-gradient
    + gradient-text: color
  }
  note for AnimatedGradientText "This component adds an animated gradient to the text."
Loading

File-Level Changes

Change Details Files
Added an animated gradient text component.
  • Created a new AnimatedGradientText component with gradient animation and styling.
  • Added gradient background and border using CSS.
  • Implemented a keyframe animation for the gradient effect.
  • Added hover effect with adjusted spacing and box-shadow.
  • Included a slot for component content.
packages/altair-docs/.vitepress/theme/components/AnimatedGradientText.vue
Integrated the animated gradient text component into the home hero section.
  • Imported the AnimatedGradientText component in Home.vue.
  • Replaced the original text in heroSublimeAction with the AnimatedGradientText component.
  • Added VPIconChevronRight to the AnimatedGradientText component.
  • Added retro grid background to the hero section.
packages/altair-docs/.vitepress/theme/components/Home.vue
packages/altair-docs/index.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eioluseyi - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a more descriptive name than AnimatedGradientText to better reflect the component's purpose.
  • The retro grid effect looks interesting, but make sure it doesn't distract from the main content or negatively impact performance.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Collaborator

@imolorhe imolorhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a merge conflict

@imolorhe imolorhe added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 26, 2025
@imolorhe
Copy link
Collaborator

@eioluseyi you will need to rebase the PR instead of creating a merge conflict.

@eioluseyi
Copy link
Contributor Author

I'm not sure why there are conflicts and I am not allowed to resolve them.
Even when I tried on my local, there were no conflicts

@imolorhe imolorhe added this pull request to the merge queue Feb 26, 2025
Merged via the queue into altair-graphql:master with commit 776f4b4 Feb 26, 2025
11 of 14 checks passed
@imolorhe
Copy link
Collaborator

@eioluseyi I made changes to the CSS variables from your last PR which also changed the formatting (will need to get the formatting sorted out as a precommit hook) so you needed to pull before making changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants