-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eio/home-hero #2782
Eio/home-hero #2782
Conversation
Reviewer's Guide by SourceryThis pull request introduces an animated gradient text component to the home hero section, enhancing the visual appeal with a dynamic gradient effect and retro grid background. The AnimatedGradientText component is used to wrap the 'Discover Altair GraphQL Cloud' text, providing a visually engaging link. Class diagram for AnimatedGradientText componentclassDiagram
class AnimatedGradientText {
+ gradient-background: linear-gradient
+ gradient-text: color
}
note for AnimatedGradientText "This component adds an animated gradient to the text."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @eioluseyi - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a more descriptive name than
AnimatedGradientText
to better reflect the component's purpose. - The retro grid effect looks interesting, but make sure it doesn't distract from the main content or negatively impact performance.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
packages/altair-docs/.vitepress/theme/components/AnimatedGradientText.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have a merge conflict
@eioluseyi you will need to rebase the PR instead of creating a merge conflict. |
I'm not sure why there are conflicts and I am not allowed to resolve them. |
50ea42b
to
cb834b4
Compare
776f4b4
@eioluseyi I made changes to the CSS variables from your last PR which also changed the formatting (will need to get the formatting sorted out as a precommit hook) so you needed to pull before making changes |
Fixes
Add an animated gradient text component fon the home hero
Checks
yarn test-build
Changes proposed in this pull request:
Add an animated gradient text component fon the home hero
Summary by Sourcery
New Features: