Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retro grid effect to home hero #2781

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

eioluseyi
Copy link
Contributor

@eioluseyi eioluseyi commented Feb 24, 2025

Fixes

Adds the retro grid effect to the home hero.
Here's the effect for reference

Checks

  • Ran yarn test-build
  • Updated relevant documentations
  • Updated matching config options in altair-static

Changes proposed in this pull request:

Add the retro grid effect to the home hero.
With configurable css variables:

.retro-grid {
  --perspective: <length>;
  --retro-grid-angle: <angle>;
  --fade-start: <length-percentage>;
  --fade-end: <length-percentage>;
  --grid-color: <color>;
  --grid-height: <length-percentage>;
  --duration: <time>;
  ...
}

Summary by Sourcery

This pull request introduces a retro grid effect to the home hero section of the documentation site. The effect is implemented using CSS and is customizable via CSS variables.

New Features:

  • Added a retro grid effect to the home hero section, enhancing the visual appeal of the homepage.

Enhancements:

  • The retro grid effect is customizable via CSS variables, allowing for easy adjustments to perspective, angle, fade, color, height, width, and animation duration.

Copy link

sourcery-ai bot commented Feb 24, 2025

Reviewer's Guide by Sourcery

This pull request implements the retro grid effect on the home hero section. It introduces a new retro-grid element with associated CSS to create the visual effect. The effect is customizable via CSS variables, allowing adjustments to perspective, angle, colors, and animation.

Class diagram for Home.vue component

classDiagram
  class Home {
    +fm.hero: Object
    +fm.features: Array
    +fm.downloads: Array
    +theme: Object
  }
  Home : - hero-content
  Home : - image-wrapper
  Home : - retro-grid
  Home : - features-section
  Home : - footer
  class RetroGrid {
    +--perspective: length
    +--retro-grid-angle: angle
    +--fade-start: length-percentage
    +--fade-end: length-percentage
    +--grid-color: color
    +--grid-height: length
    +--duration: time
  }
  note for RetroGrid "New retro grid effect with configurable CSS variables"
Loading

File-Level Changes

Change Details Files
Added a retro grid effect to the home hero section with configurable CSS variables.
  • Added a retro-grid div containing a retro-grid-composition div to the hero section.
  • Added CSS variables for customizing the grid's perspective, angle, fade, color, height, width, and animation duration.
  • Implemented an animation to create the sliding grid effect.
packages/altair-docs/.vitepress/theme/components/Home.vue

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eioluseyi - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment to explain the magic numbers used in the CSS for the retro grid effect.
  • It would be good to ensure the retro grid effect is visually appealing and performant across different screen sizes and devices.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@imolorhe imolorhe added this pull request to the merge queue Feb 24, 2025
Merged via the queue into altair-graphql:master with commit a4bc4f0 Feb 24, 2025
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants