-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable plugin manager with hardcoded list of approved plugins #2773
Conversation
Reviewer's Guide by SourceryThis pull request improves the type schema generation to be more flexible, enables the plugin manager with a hardcoded list of approved plugins, updates dependencies, removes unused files, and updates import paths. Updated class diagram for APSPluginDefinitionclassDiagram
class APSPluginDefinition {
+id: string
+name: string
+description: string
+author: string
+repository: string
+homepage?: string
}
note for APSPluginDefinition "Represents the definition of a plugin from the Altair Plugin Server."
Class diagram for APSPluginListResponseclassDiagram
class APSPluginListResponse {
+plugins: APSPluginDefinition[]
}
class APSPluginDefinition {
+id: string
+name: string
+description: string
+author: string
+repository: string
+homepage?: string
}
APSPluginListResponse -- APSPluginDefinition : contains
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @imolorhe - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a script to automatically generate the
plugins.yaml
file from the plugin manifests to avoid manual updates and potential inconsistencies. - The plugin list API endpoint is now configurable via the environment, which is great for different environments.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Visit the preview URL for this PR (updated for commit e9b1d8e): https://altair-gql--pr2773-imolorhe-re-enable-p-zj9di79s.web.app (expires Sat, 01 Mar 2025 21:03:21 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 02d6323d75a99e532a38922862e269d63351a6cf |
Improved type schema generation to be more flexible
Checks
yarn test-build
Changes proposed in this pull request:
Summary by Sourcery
This pull request introduces a plugin manager to the application, allowing users to browse, install, and remove plugins. It also improves the type schema generation process to be more flexible and automated. The plugin list is now fetched from a static JSON file within the documentation site, improving reliability and control over plugin availability.
New Features:
Enhancements:
typescript-json-schema
andajv
to generate JSON schemas and validation functions from TypeScript interfaces.Build:
CI:
Deployment:
Documentation:
Tests: