Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support flatpak #2746

Merged
merged 10 commits into from
Dec 31, 2024
Merged

support flatpak #2746

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b4ceff7
support flatpak
imolorhe Dec 31, 2024
c0dfb9b
added DEBUG env variable
imolorhe Dec 31, 2024
0e933d9
remove flatpak runtime version
imolorhe Dec 31, 2024
40c8a1c
added runtime and version for flatpak
imolorhe Dec 31, 2024
ef66a3a
install flathub repo
imolorhe Dec 31, 2024
81a34f3
additional flatpak installs
imolorhe Dec 31, 2024
fb3fe5f
removed sudo from remote-add --user command
imolorhe Dec 31, 2024
91cc5d4
removed --user flag
imolorhe Dec 31, 2024
26d976f
replace set-output with GITHUB_OUTPUT
imolorhe Dec 31, 2024
17f9462
re-add old getversion step
imolorhe Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/_publish-electron.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ jobs:
run: |
mkdir -p ~/private_keys/
echo '${{ secrets.apple_api_key }}' > ~/private_keys/AuthKey_${{ secrets.apple_api_key_id }}.p8
- name: Install flatpak and flatpak-builder
run: sudo apt-get install -y flatpak flatpak-builder
if: startsWith(matrix.os, 'ubuntu')
- name:
Build/release Electron app
# disable for macos not in master branch, because code signing is skipped in pull requests
Expand Down
15 changes: 13 additions & 2 deletions packages/altair-electron/electron-builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
appId: com.xkoji.altair
productName: Altair GraphQL Client
electronVersion: 26.2.2
electronVersion: 33.2.1
directories:
buildResources: resources
output: out
Expand All @@ -24,6 +24,7 @@ mac:
- arm64
icon: resources/mac_icon.icns
hardenedRuntime: true
darkModeSupport: true
entitlements: resources/entitlements.mac.plist
entitlementsInherit: resources/entitlements.mac.plist
strictVerify: false
Expand All @@ -33,10 +34,16 @@ dmg:
linux:
artifactName: ${name}_${version}_${arch}_linux.${ext}
icon: resources/icons
category: Development
maintainer: info@altairgraphql.dev
target:
- AppImage
- target: AppImage
arch:
- x64
- arm64
- deb
- snap
- flatpak
appImage:
category: Development
snap:
Expand All @@ -50,6 +57,10 @@ snap:
bind: $SNAP/usr/share/libdrm
win:
artifactName: ${name}_${version}_${arch}_win.${ext}
flatpak:
artifactName: ${name}_${version}_${arch}_flatpak.${ext}
runtimeVersion: '24.08'
baseVersion: '24.08'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: The specified Flatpak runtime version '24.08' is a future version that hasn't been released yet.

Consider using the current stable runtime version (like '23.08') to ensure immediate build compatibility.

electronCompile: false
protocols:
name: Altair GraphQL Client
Expand Down
Loading