Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aplay: Print '=== PAUSE ===' only if it is supported #271

Closed
wants to merge 1 commit into from
Closed

aplay: Print '=== PAUSE ===' only if it is supported #271

wants to merge 1 commit into from

Commits on Jul 22, 2024

  1. aplay: Print '=== PAUSE ===' only if it is supported 

    Instead of printing the '=== PAUSE ===' unconditionally before calling
do_pause(), move it to the function and only print it if the stream can
be paused.

If the stream cannot be paused that the '=== PAUSE ===' will be replaced
by `PAUSE command ignored (no hw support)` immediately, which is not
observable by users but automation scripts will catch the '=== PAUSE ==='
and might think that the stream is indeed got paused.

Move the print into do_pause() function after the snd_pcm_pause() have
returned without error to make sure it is only printed if the stream is
paused and we are waiting for the pause release from user to proceed.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
    @ujfalusi
    ujfalusi committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    2185bc7 View commit details
    Browse the repository at this point in the history