Add Toradex Hardware Configuration Files #448
Conversation
ucm2/Toradex/apalis/eval-HiFi.conf
Outdated
| DisableSequence [ | ||
| cset "name='Headphone Switch' off" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Overall: Missing PCM device specifications (Values) ....
There was a problem hiding this comment.
I added the Value node, please let me know... thanks!
ucm2/Toradex/apalis/eval.conf
Outdated
| } | ||
|
|
||
| BootSequence [ | ||
| cset "name='Headphone Volume' 50%" |
There was a problem hiding this comment.
Overall: If hardware supports volume control, it should be speciified e.g. using PlaybackMixerElem.
There was a problem hiding this comment.
I added this to the Value, please let me know, thanks!
ucm2/Toradex/apalis-imx6/HiFi.conf
Outdated
| @@ -0,0 +1,13 @@ | |||
| # Use case configuration for Toradex Apalis iMX6 | |||
There was a problem hiding this comment.
Use ucm2/NXP paths (like current NXP/iMX8 etc.). We prefer to store configurations for similar hardware in one place.
There was a problem hiding this comment.
@perexg : can you explain better what would you like? These UCM files are related to Toradex board, the actual sound card on these boards does not have much in common with NXP nor i.MX8 boards..
Or maybe you want the boards that use the fsl-asoc-card to be grouped together? How?
There was a problem hiding this comment.
NXP is platform in this case. I think that the best place is something like (subdirectory names):
ucm2/NXP/iMX6/Toradex/apalis
ucm2/NXP/iMX8/Toradex/apalis-eval
ucm2/NXP/iMX8/Toradex/apalis
etc...
There was a problem hiding this comment.
Ok, got it.
@perexg : One comment, this does not applies for all this file.
The boards are modular, made of a SoM, that plugs into a carrier board. The carrier boards are generic and different SoM can be plugged into those with a fully modular system.
When the sound card is part of the SoM, what you ask works fine.
Sometime, specifically for the verdin sound card, it is on the carrier board. And the exact same ucm file works whatever the SoM has an NXP soc or a TI one (just a couple of real examples we have). In that case we would have to keep the ucm2 out of the NXP directory.
We would end-up with a mix, some files in ucm2/NXP/${soc}/Toradex/${board}, some files in ucm2/Toradex/${board}.
Is this ok?
There was a problem hiding this comment.
For non-platform specific configs, I would put files to ucm2/IO-Boards/Toradex tree. It would make clear, that this config may be shared with multiple SoC combinations. The name is inspired by Raspberry. Thanks.
There was a problem hiding this comment.
Hi, I pushed the requested changes. Please let me know if something needs to be fixed. Thanks.
ucm2/Toradex/verdin/dahlia-HiFi.conf
Outdated
| SectionDevice."Headphone" { | ||
| Comment "Headphone" | ||
|
|
||
| BootSequence [ |
There was a problem hiding this comment.
Overall: BootSequence must be in top configuration files.
hiagofranco
force-pushed
the
add-tdx-boards
branch
from
d0719be to
aa9ee2d
Compare
|
@perexg : any feedback on this? changes were implemented |
…uation Board Add support for the Toradex Apalis Evaluation Board carrier board using the NAU8822 audio codec. This is a carrier board for the Apalis family, where any Apalis SoM (iMX8, iMX6...) can be connected to it, therefore this is being added to the IO-Boards instead of a specific hardware vendor. Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
… iMX8 SoM Add support for the Toradex Apalis iMX8 system on module, using the SGTL5000 audio codec. Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
… iMX6 SoM Add support for the Toradex Apalis iMX6 system on module, using the SGTL5000 audio codec. Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
…ibri iMX8X Add support for the Toradex Colibri iMX8X system on module, using the SGTL5000 audio codec. Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
…ri iMX7 SoM Add support for the Toradex Colibri iMX7 system on module, using the SGTL5000 audio codec. Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
…ri iMX6 SoM Add support for the Toradex Colibri iMX6 system on module, using the SGTL5000 audio codec. Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
…ia Board Add support for the Toradex Verdin Dahlia carrier board, using the WM8904 audio codec. This is a carrier board for the Verdin family, where any Verdin SoM (NXP, TI...) can be connected to it, therefore this is being added to the IO-Boards instead of a specific hardware vendor. Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
…lopment Board Add support for the Toradex Verdin Development carrier board, using the NAU8822 audio codec. This is a carrier board for the Verdin family, where any Verdin SoM (NXP, TI...) can be connected to it, therefore this is being added to the IO-Boards instead of a specific hardware vendor. Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
hiagofranco
force-pushed
the
add-tdx-boards
branch
from
aa9ee2d to
a2865a4
Compare
Add necessary configuration files related to Toradex Hardware.