Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community/rust: changes to add initial support for ppc64le #4549

Closed
wants to merge 1 commit into from

Conversation

mksully22
Copy link
Contributor

Patch set includes changes to libc and liblibc subdirs to support definitions for ppc64le. An initial PR was submitted to rust-lang/libc#1023 to add these changes in the long term to the libc project.

There are currently some limitations when building for ppc64le. When running with parallelism the build will intermittently stall, even with the "-j 1" parameter (looks like rustc internal job server still splits out multiple instances for rustc work). To workaround that for now taskset to cpu 0 is added. This problem will be investigated further.

Also a number of the check() tests fail on ppc64le which will also need further investigation with the rust team. For now check() had been made conditional for ppc64le.

These patches have been used to create rustc, rustc-std, and cargo binaries. For reference a github project has been setup that contains the methodology used as well as the output (tar.gz and apk files) https://github.com/mksully22/ppc64le_alpine_rust_1.26.2

@rgdoliveira rgdoliveira requested a review from jirutka June 19, 2018 08:32
kennytm added a commit to kennytm/rust that referenced this pull request Jul 5, 2018
rust: add initial changes to support powerpc64le musl

Initial changes to support rustc building on ppc64le with musl. A PR was also submitted to libc component rust-lang/libc#1023 to add changes to libc musl definitions.

A PR was submitted on Alpine alpinelinux/aports#4549 with equivalent temporary patches for building on Alpine for now.

As a verification test a github project was put together to build ppc64le versions of rustc, rust-stdlib, and cargo on Alpine, https://github.com/mksully22/ppc64le_alpine_rust_1.26.2
@ncopa
Copy link
Contributor

ncopa commented Jul 16, 2018

looks like it needs to be rebased against rust 1.27.0

@mksully22
Copy link
Contributor Author

Ok, I'll take a look at rebasing the patches to the new 1.27.0 level

@rgdoliveira
Copy link
Member

@mksully22 Is there any progress on the rebase of this PR?

@mksully22
Copy link
Contributor Author

@rgdoliveira I spent some time on the rebase to 1.27.0 but couldn't get the get the compiler code to re-compile itself sucessfully. I hope to get back to this later for further investigation.

@ncopa
Copy link
Contributor

ncopa commented Nov 22, 2018

@mksully22 any chance to get this fixed before v3.9 release (before 1 Dec)?

@mksully22
Copy link
Contributor Author

mksully22 commented Nov 23, 2018 via email

@stale
Copy link

stale bot commented Mar 3, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be automatically closed if no further activity occurs in the next 14 days. If you are still waiting for a review or response from one of our developers you can leave a comment to remove the stale label. If you know the username of the maintainer of the aport you could try to mention the username in the comment. You can also join our IRC channels on freenode and see if you can find an available developer. Thank you for your contributions.

@stale stale bot added the S-stale label Mar 3, 2019
@stale
Copy link

stale bot commented Mar 17, 2019

This pull request has been automatically closed.

@stale stale bot closed this Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants