Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error: TypeError: i is not a function #4204

Merged
merged 2 commits into from
May 13, 2024
Merged

Fix error: TypeError: i is not a function #4204

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c89ce06
Fix error: TypeError: i is not a function
fredden May 10, 2024
62cc3ec
Use optional-chaining operator
fredden May 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/alpinejs/src/directives/x-transition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ window.Element.prototype._x_toggleAndCascadeWithTransitions = function (el, valu
let carry = Promise.all([
el._x_hidePromise,
...(el._x_hideChildren || []).map(hideAfterChildren),
]).then(([i]) => i())
]).then(([i]) => i && i())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
]).then(([i]) => i && i())
]).then(([i]) => i?.())

Not sure if we want to reopen this can of worms with people using decade old webpack versions that can't support optional chaining, but we can dream.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. Support for optional chaining seems to be wide-spread now: https://caniuse.com/mdn-javascript_operators_optional_chaining
And it seems that we're already using this feature in this code-base, so let's use this here.

alpine/packages/alpinejs/src/scope.js

Line 74 in 0d5a190

if (descriptor?.set && descriptor?.get)

alpine/packages/ui/src/combobox.js

Line 27 in 0d5a190

let active = data.__context?.getActiveItem()


delete el._x_hidePromise
delete el._x_hideChildren
Expand Down
Loading