x-mask: Cleanup of event listeners #3908
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Found a bug when using x-mask with Livewire. Problem is sometimes input changed by Livewire and mask directive intiated every time. Adding cleanup of event listeners fix this issue.
Unfortunately don't know how to make correct tests for this situation without LW part, but you can check it on this wirebox: https://wirebox.app/b/4kwle
To reproduce:
12345
string6
(to get123456
string) in both fields. First field has weird behaviour, second field is OK.Second field has patched version of mask plugin.