fix: reset input on init so default value is displayed #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry. My editor has some defaults that are different than the codebase that I didn't notice until I opened the PR. |
|
@coder2000 can you revert your formatting changes so it's possible to review this? This bug has been killing me but it took me forever to figure out what actually changed in this PR. |
Done. |
|
fixed and added tests, thanks! |
This was referenced Jul 10, 2024
This was referenced Jul 16, 2024
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when setting a default value for the combobox it isn't displayed right away. You would have to open and close it before the display value would be visible. This will reset the input as part of the init so the value is displayed right away.