Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always add a user #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Always add a user #66

wants to merge 1 commit into from

Conversation

ffes
Copy link

@ffes ffes commented Mar 5, 2024

This PR always adds a user git-user. The adduser command is inspired on your stale non-root branch.

My reason to always add a user, but not use, is to have the possibility to use it as a devcontainer in vscode.

I have a couple of repositories that I use to maintain my notes on various subjects. In vscode when you want to use a devcontainer as non-root, vscode requires to have that there is a user available in the container. There is no easy way to add it afterwards unless you create a new Dockerfile and use that to build your own base-devcontainer. So by always adding the user, I can use this container in vscode really easily.

I tried to pull your alpine/git:user from docker hub, but that is too old and doesn't work with vscode.

As far as I can see, adding this doesn't bother the current users who use the container as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant