Reduce the number of queries used to build ministers index links #9418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanb-gds
force-pushed
the
reduce-ministers-index-queries
branch
from
769cdd3
to
27f7a96
Compare
The ministers index presenter was not leveraging eager loading and consequently was running huge numbers of queries. This has the potential to cause performance issues in the Sidekiq queues, as indeed was recently the case with the embassies index presenter. We also move the govspeak helper from the main presenter to the reshuffle presenter because the main presenter doesn't use any of the methods it provides.
ryanb-gds
force-pushed
the
reduce-ministers-index-queries
branch
from
27f7a96
to
615905c
Compare
dnkrj
approved these changes
Sep 5, 2024
There's this existing one: https://github.com/alphagov/whitehall/blob/main/test/unit/app/presenters/publishing_api/ministers_index_presenter_test.rb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ministers index presenter was not leveraging eager loading and consequently was running huge numbers of queries. This has the potential to cause performance issues in the Sidekiq queues, as indeed was recently the case with the embassies index presenter.
We also remove the unused govspeak helper from the presenter.
I've tested this in integration and it produces exactly the same list of links as the current presenter.