Remove external link styles #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes external link styles: https://github.com/alphagov/govuk_frontend_toolkit/blob/master/CHANGELOG .md
After static was updated to latest toolkit, the external link image disappeared, breaking the display of external links in apps. * Remove use of mixins no longer provided by toolkit * Remove white external link shim * Remove white external link images Original PR and discussion: alphagov/govuk_frontend_toolkit#293
* Accordion not accordian. * Keep Whitehall consistent with frontend toolkit.
|
Guess we want to get rid of as well? |
|
Also this block might not be needed? Apart from that it looks good. |
The symbol no longer appears next to the link.
|
@robinwhittleton Thanks for the review. I've removed the guidance about the icon. The second bit is part of the admin UI and is a different kind of icon/feature which can be left in. |
robinwhittleton
approved these changes
Nov 21, 2016
|
Great work thanks @fofr 👍 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After static was updated to latest toolkit, the external link styles were removed but some extra styles still remained in Whitehall, breaking the display of external links.
Original PR and discussion:
alphagov/govuk_frontend_toolkit#293
cc @NickColley