Remove external link styles

After static was updated to latest toolkit, the external link image disappeared, breaking the display of external links in apps. * Remove use of mixins no longer provided by toolkit * Remove white external link shim * Remove white external link images Original PR and discussion: alphagov/govuk_frontend_toolkit#293
alphagov · Nov 18, 2016 · 6c60018 · 6c60018
1 parent 4ad83f3
commit 6c60018
Show file tree

Hide file tree

Showing 11 changed files with 0 additions and 61 deletions.
diff --git a/app/assets/images/external-link-white-12x12.png b/app/assets/images/external-link-white-12x12.png
diff --git a/app/assets/images/external-link-white-24x24.png b/app/assets/images/external-link-white-24x24.png
diff --git a/app/assets/stylesheets/frontend/global/_links.scss b/app/assets/stylesheets/frontend/global/_links.scss
@@ -16,16 +16,8 @@ a {
   &:focus {
     text-decoration: underline;
   }
-  &[rel="external"] {
-    @include external-link-13-no-hover;
-    @include media(tablet) {
-      @include external-link-19-no-hover;
-    }
-  }
 
   * {
     cursor: pointer;
   }
 }
-
-
diff --git a/app/assets/stylesheets/frontend/helpers/_attachment.scss b/app/assets/stylesheets/frontend/helpers/_attachment.scss
@@ -80,9 +80,6 @@ $thumbnail-width: 99px;
   .opendocument-help {
     margin: 0;
     @include ig-core-14;
-    a {
-      @include external-link-14;
-    }
   }
 
   .accessibility-warning {

diff --git a/app/assets/stylesheets/frontend/helpers/_featured-links.scss b/app/assets/stylesheets/frontend/helpers/_featured-links.scss
@@ -12,12 +12,5 @@
     @include media(tablet) {
       padding-bottom: $gutter-one-sixth;
     }
-
-    a[rel="external"] {
-      @include external-link-14-bold-no-hover;
-      @include media(tablet) {
-        @include external-link-16-bold-no-hover;
-      }
-    }
   }
 }
diff --git a/app/assets/stylesheets/frontend/helpers/_featured_news.scss b/app/assets/stylesheets/frontend/helpers/_featured_news.scss
@@ -63,9 +63,6 @@
           padding-top: 0;
           a {
             font-weight: bold;
-            &[rel=external] {
-              @include external-link-19-bold-no-hover;
-            }
           }
         }
         h3 {
@@ -80,4 +77,3 @@
     }
   }
 }
-
diff --git a/app/assets/stylesheets/frontend/helpers/_metadata-list.scss b/app/assets/stylesheets/frontend/helpers/_metadata-list.scss
@@ -51,13 +51,6 @@
       }
     }
 
-    a[rel="external"] {
-      @include external-link-12;
-      @include media(tablet) {
-        @include external-link-14;
-      }
-    }
-
     .change-notes-title {
       @include media(desktop){
         clear: left;

diff --git a/app/assets/stylesheets/frontend/styleguide/_typography.scss b/app/assets/stylesheets/frontend/styleguide/_typography.scss
@@ -121,32 +121,14 @@
   }
 }
 
-// TODO (@bfirsh): refactor frontend_toolkit external link mixin to work with 
-// white icons: https://github.com/alphagov/govuk_frontend_toolkit/pull/51
-@mixin external-link-white {
-  &:after {
-    background-image: image-url("external-link-white-12x12.png");
-    background-repeat: no-repeat;
-
-    @include device-pixel-ratio() {
-      background-image: image-url("external-link-white-24x24.png");
-      background-size: 12px 400px;
-    }
-  }
-}
-
 @mixin white-links {
   a,
   a:visited,
   a:hover {
     color: $white;
     text-decoration: underline;
-    &[rel="external"] {
-      @include external-link-white;
-    }
   }
   a:active {
     color: $link-active-colour;
   }
 }
-
diff --git a/app/assets/stylesheets/frontend/views/_html-publications.scss b/app/assets/stylesheets/frontend/views/_html-publications.scss
@@ -280,10 +280,6 @@
           ol+p {
             margin-top: $gutter-one-third;
           }
-
-          a[rel="external"] {
-            @include external-link-14;
-          }
         }
       }
 

diff --git a/app/assets/stylesheets/frontend/views/_organisations.scss b/app/assets/stylesheets/frontend/views/_organisations.scss
@@ -998,9 +998,6 @@
         ul {
           margin-top: $gutter-one-third;
         }
-        a[rel=external] {
-          @include external-link-16-bold-no-hover;
-        }
       }
       .large {
         ul {

diff --git a/app/assets/stylesheets/frontend/views/_world_locations.scss b/app/assets/stylesheets/frontend/views/_world_locations.scss
@@ -97,13 +97,6 @@
           li {
             list-style: none;
             margin-bottom: $gutter-one-sixth;
-
-            a[rel="external"] {
-              @include external-link-14-bold-no-hover;
-              @include media(tablet) {
-                @include external-link-16-bold-no-hover;
-              }
-            }
           }
         }
         @include media(tablet) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -280,10 +280,6 @@ @@
               ol+p {
                 margin-top: $gutter-one-third;
               }
-              a[rel="external"] {
-                @include external-link-14;
-              }
             }
           }
@@ Expand Down @@