All changes labelled for version 4 + David H's commit #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try to avoid left menu jumping around
With this commit, we are just updating the ruby version for the example project since the current version is old and no longer supported.
When we wrap images in hyperlinks, we make the image's alt text their only content. If those images have no alt text, they are effectively empty links. This means they have no accessible name if queried by an accessibility API: https://w3c.github.io/html-aam/#img-element-accessible-name-computation ...so it'll be up to the screen reader to guess. In testing, this ends up being the file name, which can't be relied on to explain the image. All in all, this behaviour breaks the non-text content success criterion from WCAG 2.2: https://www.w3.org/WAI/WCAG22/Understanding/non-text-content.html This issue is recorded here: #355 This commit take the approach of introducing a guard against images with no alt text and choosing not to wrap them in hyperlinks when found. My Ruby is basic at best but I looked at the method we're overwriting from the Red Carpet HTML renderer and copied across its interface more exactly, to make it clear where the alt_text variable comes from.
Rewrite alt text guard to be more exact
we're no longer targeting any IE prior to 11, so removing this out, see: https://github.com/alphagov/govuk-frontend/blob/main/CHANGELOG.md#500-breaking-release
Import using "all" has been deprecated https://github.com/alphagov/govuk-frontend/releases#:~:text=Importing%20layers%20using%20all%20files
govuk-frontend As govuk-frontend encourages its use within script type=module, we need to create a separate entry for it as we do not want any downstrema project to change the way they write their own javascript. This PR - adds a new zgovuk_frontend.js` include to core layout - removes `all.js` import from `govuk_tech_docs.js` - creates a new `govuk_frontend_all.js` entry in the lib that imports `all.bundle.js` from the NPM package - adds a new `govuk_frontend.js` entry point in the example project that pulls in the `govuk_frontend_all.js` from the lib - adds new minifier - https://github.com/ahorek/terser-ruby as the built-in one doesn't support ES6
To do: see if we can configure to silence warning Built-in sassc compiler doesn't compile stylesheet do to them, containing source maps https://github.com/sass-contrib/sassc-embedded-shim-ruby
No longer needed with the upgrade to v5
- update to the new crown svg https://github.com/alphagov/govuk-frontend/releases#:~:text=If%20you%E2%80%99re%20not%20using%20the%20Nunjucks%20macro%2C%20locate%20the%20SVG%20code%20for%20the%20existing%20logo%20and%20replace%20it%20with%20this%20updated%20SVG. - remove redundant markup https://github.com/alphagov/govuk-frontend/releases?page=2#:~:text=Update%20the%20GOV.UK%20logo
This change adds checks to ensure that this.$sticky exists and it is visible before trying to access its methods. Further information at #368
Following a PR review[1], this commit changes the test on this.$sticky, in order to verify if the object actually contains any elements. Further details in the PR[2]. [1] #368 (comment) [2] #368
With this change, we have defined a custom SassWarningSupressor module that overrides the warn method so that we can ignore messages containing 'sass' or 'dart-sass' only. This is needed so that we can avoid sass warnings in downstream projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains all the changes in the PRs that have been labelled for the release of version 4.
It also contains David H's unrelated commit that fixes a problem with the menu.