Fix Nokogiri Node.new deprecation warnings
#296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 16, 2022 11:07
Reproduces the deprecation warning in the example app
timja
commented
Mar 16, 2022
| @@ -69,7 +69,7 @@ def table_row(body) | |||
| first_child.content = leading_text.sub(/# */, "") | |||
| end | |||
|
|
|||
| tr = Nokogiri::XML::Node.new "tr", fragment | |||
| tr = Nokogiri::XML::Node.new "tr", fragment.document | |||
There was a problem hiding this comment.
this change can be tested by viewing:
http://localhost:4567/code.html
If you checkout just the first commit you will see the deprecation warning, if you then apply the second commit you will see it fixed
timja
commented
Mar 16, 2022
Comment on lines
+98
to
+100
| pre = Nokogiri::XML::Node.new "pre", fragment.document | ||
| pre["tabindex"] = "0" | ||
| code = Nokogiri::XML::Node.new "code", fragment | ||
| code = Nokogiri::XML::Node.new "code", fragment.document |
There was a problem hiding this comment.
Wasn't sure how to test these, it appears to be a fallback for when you don't have a source code highlighter, but I think it should be okay given the other change worked.
timja
commented
Mar 16, 2022
| </div> | ||
| | httpResult | Message | How to fix | | ||
| | - | - | - | | ||
| | `400` | `[{`<br>`"error": "BadRequestError",`<br>`"message": "Can't send to this recipient using a team-only API key"`<br>`]}` | Use the correct type of API key | |
There was a problem hiding this comment.
Credit to https://alvinalexander.com/text/how-put-multiple-lines-markdown-table-cell-multiline-table/ on how to do a multi-line markdown table 🎉
lfdebrux
changed the title
lfdebrux
changed the title
Node.new deprecation warnings
lfdebrux
approved these changes
Mar 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #295
What’s changed
Deprecation warnings from Nokogiri addressed when rendering markdown tables
Identifying a user need
Not spamming my logs pls and thank you
cc @lfdebrux