Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog to add new 'relative links' feature #293

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

lfdebrux
Copy link
Member

What’s changed

Updates changelog to include new features from PR #291.

@lfdebrux
Copy link
Member Author

@PippaClarkGDS you may want to change this substantially, feel free to.

@lfdebrux lfdebrux changed the title Update changelog Update changelog to include new 'relative links' feature Feb 17, 2022
@lfdebrux lfdebrux changed the title Update changelog to include new 'relative links' feature Update changelog to add new 'relative links' feature Feb 17, 2022
@lfdebrux lfdebrux linked an issue Feb 17, 2022 that may be closed by this pull request
Copy link
Contributor

@PippaClarkGDS PippaClarkGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have inputted the release note text

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: PippaClarkGDS <49393034+PippaClarkGDS@users.noreply.github.com>
Copy link
Contributor

@PippaClarkGDS PippaClarkGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small tweak to include the release note number, otherwise looks good

@@ -2,6 +2,14 @@

## Unreleased

### New features
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I was gonna add in that in a subsequent release PR, just makes more sense to me that way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah great - is that the usual way it's done? If so, I'll approve it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, at least on other projects I've worked on.

@@ -2,6 +2,14 @@

## Unreleased

### New features
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I was gonna add in that in a subsequent release PR, just makes more sense to me that way.

@PippaClarkGDS PippaClarkGDS self-requested a review March 9, 2022 10:31
Copy link
Contributor

@PippaClarkGDS PippaClarkGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved without the numbering as this will be in the release PR

@lfdebrux lfdebrux merged commit 71febdb into master Mar 9, 2022
@lfdebrux lfdebrux deleted the ldeb-update-changelog branch March 9, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make docs portable by using relative URLs
2 participants