Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sites deployed on paths other than "/" (by generating relative links) #291

Merged
merged 14 commits into from
Feb 11, 2022
Merged

Support sites deployed on paths other than "/" (by generating relative links) #291

merged 14 commits into from
Feb 11, 2022

Commits on Feb 3, 2022

  1. TRG-128 - Generate Table of Content links as relative links. 

    This aims to address alphagov#271 by ensuring that all TOC links are generated as relative links, rather than absolute. The desired outcome being that the site no longer makes assumptions about being deployed at "/" which in turn makes it "portable" (i.e. possible to deploy it at an arbitrary path).
    @eddgrant
    eddgrant committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    ae07fc2 View commit details
    Browse the repository at this point in the history

  2. TRG-128: Make search function work when using generating sites using … 

    …relative links.
    @eddgrant
    eddgrant committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    17b5c8a View commit details
    Browse the repository at this point in the history

  3. TRG-128: Refactor path helpers out in to their own module. 

    Also improved the naming of a few methods and variables.
    @eddgrant
    eddgrant committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    fabb8a6 View commit details
    Browse the repository at this point in the history

  4. TRG-128: Make /api/pages.json endpoint return relative links when the… 

    … sites is configured to use relative links.
    @eddgrant
    eddgrant committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    d874c33 View commit details
    Browse the repository at this point in the history

  5. TRG-128: Make nav bar expanding, collapsing and highlighting work whe… 

    …n using generating sites using relative links.
    @eddgrant
    eddgrant committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    73080ca View commit details
    Browse the repository at this point in the history

  6. Fix Rubocop linting errors.

    @eddgrant
    eddgrant committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    a6b0eb9 View commit details
    Browse the repository at this point in the history

  7. Remove TODO

    @eddgrant
    eddgrant committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    1f2d71b View commit details
    Browse the repository at this point in the history

  8. isOnSearchPage: Remove erroneous regular expression wildcard prefix.

    @eddgrant
    eddgrant committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    749fcc5 View commit details
    Browse the repository at this point in the history

  9. changeSearchAction(): Don't pass already in-scope variable to function.

    @eddgrant
    eddgrant committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    1c3ebc8 View commit details
    Browse the repository at this point in the history

  10. Replace use of const with var.

    @eddgrant
    eddgrant committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    54ff817 View commit details
    Browse the repository at this point in the history

  11. Search: Add data-path-to-site-root attribute. 

    To ensure test code fragment matches the actual generated code.
    @eddgrant
    eddgrant committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    840a478 View commit details
    Browse the repository at this point in the history

  12. Use :http_prefix when calculating the path to the site root, when usi… 

    …ng absolute links.

This configuration setting defaults to '/' so we can rely on it to always have a value.
    @eddgrant
    eddgrant committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    7ccde80 View commit details
    Browse the repository at this point in the history

  13. TRG-128: Ensure http_prefix is not duplicated when generating search … 

    …result links.
    @eddgrant
    eddgrant committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    babdeb7 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. TRG-128: Revert back to always obtaining search results from /search.… 

    …json
    @eddgrant
    eddgrant committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    d49fef0 View commit details
    Browse the repository at this point in the history