Remove IE8 fallback PNG with broken image reference #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 0e9ac92 we updated the header in line with changes made in GOV.UK Frontend v3.13.0, which involved changing the `<image>` tag to an `<img>` tag. The path is incorrect (and was before), as the fallback PNG is actually located at `/assets/govuk/images/govuk-logotype-crown.png`. Because of the change of tag (presumably) this is now causing downstream builds that have link checkers to fail, like in alphagov/govuk-frontend-docs#139 (build log: https://app.travis-ci.com/github/alphagov/govuk-frontend-docs/builds/233880666). We could fix the path, but given the layout is already completely broken in IE8 anyway, it seems like it makes more sense just to remove the fallback logic at this point.
kr8n3r
approved these changes
Jul 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0e9ac92 we updated the header in line with changes made in GOV.UK Frontend v3.13.0, which involved changing the
<image>tag to an<img>tag.The path is incorrect (and was before), as the fallback PNG is actually located at
/assets/govuk/images/govuk-logotype-crown.png.Because of the change of tag (presumably) this is now causing downstream builds that have link checkers to fail, like in alphagov/govuk-frontend-docs#139 (build log: https://app.travis-ci.com/github/alphagov/govuk-frontend-docs/builds/233880666).
We could fix the path, but given the layout is already completely broken in IE8 anyway, it seems like it makes more sense just to remove the fallback logic at this point.