Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement row level table headings to allow accessible tables with row headings #214

Merged
merged 4 commits into from
Mar 12, 2021

Commits on Mar 11, 2021

  1. Implement table row headings

    Sometimes, tables have row-level headings as well as column level
    headings.
    
    To be accessible, these need to be marked up as `<th>` tags. Otherwise
    users of screen readers and other assistive technology may not be able
    to work out that they're table headings rather than ordinary table
    cells.
    richardTowers committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    556ef8d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3de782e View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Use nokogiri to process html, instead of regex

    This allows us to handle the more complex case where table headings
    contain other markup (e.g. the heading might have an `<em>` tag, as per
    the test).
    
    It feels less hacky than using a regex, but it's quite a bit more code
    so I'm not 100% sure whether it's an improvement.
    richardTowers committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    c061010 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bfbd1d7 View commit details
    Browse the repository at this point in the history