Stop linking images to new tabs #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanGabbianelli
force-pushed
the
stop-linking-images-to-new-tab
branch
from
a284b12
to
7a14ce9
Compare
AlanGabbianelli
changed the title
barrucadu
reviewed
Feb 25, 2021
This fixes one of our [accessibility issues][1]. Specifically, it will prevent images to link to new tabs without telling the user, which fails [WCAG 2.1 success criterion 2.4.4 Link Purpose (in context)][2]. [1]: https://docs.google.com/spreadsheets/d/1s53eGMBj2hdTVLRitwi673R-_uERWh0kOxOp9QsOVg0 [2]: https://www.w3.org/TR/UNDERSTANDING-WCAG20/navigation-mechanisms-refs.html Trello card: https://trello.com/c/vv0OR35g/630-march-update-tech-docs-template
AlanGabbianelli
force-pushed
the
stop-linking-images-to-new-tab
branch
from
7a14ce9
to
3f9ba86
Compare
barrucadu
approved these changes
Feb 25, 2021
3 tasks
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one of our accessibility issues. Specifically, it will
prevent images to link to new tabs without telling the user, which fails
WCAG 2.1 success criterion 2.4.4 Link Purpose (in context).
Trello card: https://trello.com/c/vv0OR35g/630-march-update-tech-docs-template