Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct separator for page titles #176

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Conversation

36degrees
Copy link
Contributor

Use a hyphen (-) rather than a pipe (|) within page titles to be consistent with the guidance in the Service Manual:

The <title> should be based on the <h1>, and follow this format:

Where do you live? - register to vote - GOV.UK

@36degrees
Copy link
Contributor Author

Should pass if rebased once #178 has been merged.

Use a hyphen (`-`) rather than a pipe (`|`) within page titles to be consistent with the guidance in the Service Manual [1]:

> The <title> should be based on the <h1>, and follow this format:
>
> Where do you live? - register to vote - GOV.UK

[1]: https://www.gov.uk/service-manual/design/writing-for-user-interfaces#headings-and-title
Copy link
Contributor

@m-green m-green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@36degrees 36degrees merged commit fbec1e8 into master Apr 17, 2020
@36degrees 36degrees deleted the use-correct-page-title branch April 17, 2020 12:19
36degrees added a commit that referenced this pull request Apr 20, 2020
36degrees added a commit that referenced this pull request Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants