Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure IDs on collapsible navigation are unique #160

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Make sure IDs on collapsible navigation are unique #160

merged 2 commits into from
Nov 15, 2019

Commits on Nov 15, 2019

  1. Make sure IDs on collapsible navigation are unique 

    Multiple nested pages were getting assigned the same ID (from the parent). This change
appends the iterator index to the elements to make sure they're unique.
Also added a extra nested page to the example docs and a test.
    Jakub Miarka committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    c186288 View commit details
    Browse the repository at this point in the history

  2. Fixed aria-controls attribute 

    When using multiple nested unique IDs the aria relationship broke. This
change adds the list of the nested elements in the `aria-controls` attribute.
    Jakub Miarka committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    511d1ce View commit details
    Browse the repository at this point in the history