Improve code font sizing #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easier to test different code blocks
Browser vendors have an odd behaviour and this is hacky but resolves our issues, the alternatives are not clear since different browsers handle relative units on pre, code differently.
freesteph
approved these changes
Oct 21, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not aware of a way to solve this consistently cross browser with root relative font sizing.
I'm following this hack which tricks browsers into doing the right thing: http://code.iamkate.com/html-and-css/fixing-browsers-broken-monospace-font-handling/
Screenshots
Before, code blocks font size is too large
After, code blocks font size is consistent
I have tested this in Firefox, Safari, Internet Explorer, Edge and Chrome