Accessibility improvements #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can specify the line height within the mixin
This means when users change their font size that these elements will scale alongside the rest of the text. We leave the pixel font sizes as fallbacks for older browsers. Fixes #127
As these have been given 'aria-hidden' to hide them from screen readers we should also ensure that they cannot be tabbed to. By adding 'tabindex=-1' we ensure that a screen reader user does not tab to these and get no response. Fixes #126
Previously the replace method only replaced the first white space with a hyphen. By using regex and looking for whitespace we will capture all spaces between text and create correct IDs that are unique Fixes #112
Since this content is not main content but related to it, we can use the 'aside' element to indicate this is complementary content to the main content. Fixes #111
Nested pages render links within the sidebar differently. Spans are required to show a focus state, so by adding this it makes these nested links consistent with the rest of the navigation. Fixes #114
NickColley
force-pushed
the
accessibility-improvements
branch
from
5e7f6ce
to
4a618ee
Compare
Merged
This was referenced Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the majority of accessibility issues raised from mine and @jakubmiarka 's review.
See commits for details.
Screenshots
Code elements within links
Focused