Pin openapi3_parser #121
Merged
Pin openapi3_parser #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 0.6.0 release is causing builds to fail. Pinning it to 0.5.2 appears to solve this. The maintainer of openapi3_parser has been made aware, and hopes to have a new version out soon.
|
Mostly raising this to check that it does fix the failing tests currently on master. If a new release of openapi3_parser is released soon, we may not need to merge this. |
|
@36degrees I fixed the underlying bug in openapi_parser with 0.6.1 however I discovered (much to my surprise) that this gem also relies on a method that was removed, so I'd suggest you merge this in. I'm planning to update the code in this gem for compatibility without this method and will open a fresh PR for that (after thoroughly rasping myself for not realising the significance of a BC break) and can update the gem dependency then too. Apologies for the inconveniences. |
kevindew
approved these changes
Oct 9, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 0.6.0 release is causing builds to fail. Pinning it to 0.5.2 appears to solve this.
The maintainer of openapi3_parser has been made aware, and hopes to have a new version out soon.