Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up and optimise imports #118

Merged
merged 4 commits into from
Oct 8, 2019
Merged

Tidy up and optimise imports #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0614310
Remove unused font files
36degrees Oct 4, 2019
4013ccf
Include only the bits of GOV.UK Frontend we need
36degrees Oct 4, 2019
0ead96f
Replace printable mixin with govuk-media-query
36degrees Oct 4, 2019
19bf3ea
Remove unused breakpoints
36degrees Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions lib/assets/stylesheets/_core.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
@charset "utf-8";

$tablet-breakpoint: 768px !default;
$desktop-breakpoint: 992px !default;

@import "utilities/printable";

@import "palette/syntax-highlighting";
@import "syntax-highlighting";

Expand Down
29 changes: 0 additions & 29 deletions lib/assets/stylesheets/_fonts.scss
View file
Open in desktop

This file was deleted.

19 changes: 18 additions & 1 deletion lib/assets/stylesheets/_govuk_tech_docs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,23 @@
$govuk-assets-path: "/assets/govuk/assets/";

@import "govuk/all";
// Include only the bits of GOV.UK Frontend we need
@import "govuk/settings/all";
@import "govuk/tools/all";
@import "govuk/helpers/all";

@import "govuk/core/all";
@import "govuk/objects/all";

@import "govuk/components/footer/footer";
@import "govuk/components/header/header";
@import "govuk/components/inset-text/inset-text";
@import "govuk/components/input/input";
@import "govuk/components/tag/tag";
@import "govuk/components/skip-link/skip-link";
@import "govuk/components/warning-text/warning-text";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I've done this sort of thing in the past I've left in the full component list as comments for other developers ease of use but probably is an opinionated idea.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to leave as-is, mainly because I can see a list like that going out of date relatively quickly as we introduce new components etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's a good point 👍


@import "govuk/utilities/all";
@import "govuk/overrides/all";

@import "core";
@import "vendor/fixedsticky";
2 changes: 1 addition & 1 deletion lib/assets/stylesheets/modules/_search.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
}
}

@include print {
@include govuk-media-query($media-type: print) {
.search {
display: none;
}
Expand Down
29 changes: 0 additions & 29 deletions lib/assets/stylesheets/utilities/_fonts.scss
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions lib/assets/stylesheets/utilities/_printable.scss
View file
Open in desktop

This file was deleted.