Improve meta tags and page title #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds all the appropriate meta tags to pages. This makes will improve SEO and improve previews in services like Slack, which uses both Twitter and Facebook/OpenGraph data for its unfurling.
MatMoore
approved these changes
Apr 5, 2018
tijmenb
added a commit
that referenced
this pull request
Apr 18, 2018
Since #11 the template crashes when `host` isn't specified in config/tech-docs.yml. This makes sure that we don't crash.
tijmenb
added a commit
that referenced
this pull request
Apr 18, 2018
Since #11 the template crashes when `host` isn't specified in config/tech-docs.yml. This makes sure that we don't crash.
tijmenb
added a commit
to alphagov/govuk-developer-docs
that referenced
this pull request
Feb 7, 2019
This is a bit of a big commit, but it should be fine since it's mostly deletions and it's all interconnected. Things that happen in this commit: - We remove the layout overrides that exist in these docs, in favour of the layouts provided by the gem. - The layouts now provide the meta tags functionality (alphagov/tech-docs-gem#11), so we can remove our own code for that. - The page review is now provided by the gem as well (alphagov/tech-docs-gem#12), so we get rid of the custom code for that too. - We turn on the search functionality from the gem which was added in alphagov/tech-docs-gem#28 and follow up PRs. After this commit, we're mostly running code from the gem instead of our own. This should make it easier to update, and makes it more likely that we'll contribute back to the gem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds all the appropriate meta tags to pages. This makes will improve SEO and improve previews in services like Slack, which uses both Twitter and Facebook/OpenGraph data for its "unfurling".
Example
These meta tags are currently in use on the GOV.UK developer docs. They cause Slack to show a nice preview, unlike other sites like the PaaS tech docs:
Part of the Q4 GOV.UK 🔥 firebreak: https://trello.com/c/QbspvRc2