Skip to content

Commit

Permalink
Merge pull request #373 from alphagov/fix-header-menu-button
Browse files Browse the repository at this point in the history
Fix header menu button
  • Loading branch information
kr8n3r authored Oct 23, 2024
2 parents d888afa + c6337f4 commit 5b0918c
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Changelog

## Unreleased
- Upgrade to govuk-frontend v5.6.0 and introduce new Javascript entry point
- Upgrade to govuk-frontend v5.7.1 and introduce new Javascript entry point
BREAKING: drop support for IE8

You need to
Expand Down
2 changes: 1 addition & 1 deletion lib/source/layouts/_header.erb
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<% if config[:tech_docs][:header_links] %>
<div class="govuk-header__content">
<nav class="govuk-header__navigation govuk-header__navigation--end" aria-label="Menu">
<button type="button" class="govuk-header__menu-button govuk-js-header-toggle" aria-controls="navigation" aria-label="Show or hide menu">Menu</button>
<button type="button" class="govuk-header__menu-button govuk-js-header-toggle" aria-controls="navigation" hidden>Menu</button>
<ul id="navigation" class="govuk-header__navigation-list">
<% config[:tech_docs][:header_links].each do |title, path| %>
<li class="govuk-header__navigation-item<% if active_page(path) %> govuk-header__navigation-item--active<% end %>">
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"lint": "standard"
},
"dependencies": {
"govuk-frontend": "~5.6.0"
"govuk-frontend": "~5.7.1"
},
"devDependencies": {
"standard": "^14.3.4"
Expand Down

0 comments on commit 5b0918c

Please sign in to comment.