Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'analytics' from metatags #341

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Remove 'analytics' from metatags #341

merged 1 commit into from
Sep 16, 2024

Conversation

andysellick
Copy link
Contributor

What

Rename two of our metatags to remove analytics from them.

Must be deployed with: alphagov/govuk_publishing_components#4222

Why

Making them consistent with other metatags - we don't include analytics for other tags, even though they're used by analytics.

Visual changes

None.

Trello card: https://trello.com/c/lIVmnFpY/336-page-view-enhancement-some-meta-tags-start-with-analytics

@unoduetre
Copy link
Contributor

Can you add a changelog entry under "Unreleased", please?

Copy link
Contributor

@unoduetre unoduetre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. The only thing missing is the changelog entry.

@andysellick andysellick changed the title Remove 'analytics' from metatags [DO NOT MERGE] Remove 'analytics' from metatags Sep 13, 2024
- to make this consistent with other metatags
Copy link
Contributor

@unoduetre unoduetre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andysellick andysellick changed the title [DO NOT MERGE] Remove 'analytics' from metatags Remove 'analytics' from metatags Sep 13, 2024
@andysellick andysellick merged commit 9c65f7f into main Sep 16, 2024
15 checks passed
@andysellick andysellick deleted the change-meta-tags branch September 16, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants