Update body classes for govuk frontend v5 #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinJJones
force-pushed
the
update-body-classes-for-govuk-frontend-v5
branch
2 times, most recently
from
7b67872
to
9dcf390
Compare
unoduetre
requested changes
Jun 28, 2024
For govuk-frontend v5, there now needs to be additional class added to the `body` tag to indicate that the components are supported. This class is `govuk-frontend-supported` and is added if the browser supports JS of type `module` (which is the new browser target for govuk-frontend). The script tag is directly taken from the documentation.
MartinJJones
force-pushed
the
update-body-classes-for-govuk-frontend-v5
branch
from
9dcf390
to
b23086c
Compare
unoduetre
approved these changes
Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the
<script>snippet in the test templates.Why
For govuk-frontend v5, there now needs to be additional class added to the
bodytag to indicate that the components are supported.This class is
govuk-frontend-supportedand is added if the browser supports JS of typemodule(which is the new browser target for govuk-frontend).The script tag is directly taken from the documentation, see "Update the
<script>snippet at the top of your<body>tag" in the release notes for govuk-frontend 5.0.0We can safely move to the new snippet in advance of upgrading to V5 of govuk-frontend and ensure components from govuk-frontend still initialise as expect when running integration tests from apps such as smart-answers.
Trello card