Raise more specific error when wrapper not found #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
force-pushed
the
2495-sentry-errors-investigate-frontend-nomethoderror
branch
2 times, most recently
from
9c5bd77
to
5e86edb
Compare
|
Closing this for now as another approach would be taken first. |
KludgeKML
force-pushed
the
2495-sentry-errors-investigate-frontend-nomethoderror
branch
3 times, most recently
from
6df2e5a
to
f7a8be2
Compare
KludgeKML
force-pushed
the
2495-sentry-errors-investigate-frontend-nomethoderror
branch
from
f7a8be2
to
5b35b16
Compare
leenagupte
approved these changes
May 31, 2024
| @@ -26,5 +26,9 @@ def filter(src, dest) | |||
| def is_gem_layout? | |||
| @headers[Slimmer::Headers::TEMPLATE_HEADER]&.start_with?("gem_layout") | |||
| end | |||
|
|
|||
| def wrapper_check? | |||
| ENV["SLIMMER_WRAPPER_CHECK"] == "true" | |||
There was a problem hiding this comment.
So it will be "off" by default, that's nice.
unoduetre
deleted the
2495-sentry-errors-investigate-frontend-nomethoderror
branch
This was referenced Jun 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When wrapper is not found it results in a method being called on
nil, which producesNoMethodError. For the purposes of investigating the error in the attached Trello card it would be useful to produce a more meaningful error containing some additional information which could help the investigation.(Have added a feature flag, so this is only active when SLIMMER_WRAPPER_CHECK=true is set in the host app)
Why
To facilitate the investigation of the error in the Trello card