Allow alerts to be posted to a different Slack channel #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, PR review reinders are sent to the Slack channel of the team who own the application. Some teams may wish to have automated alerting sent to a different channel. Therefore updating to use the `alerts_team` value instead of the `team` value. By default, `govuk-developer-docs` falls back to the `team` value [1] where no other value is specified. 1:https://github.com/alphagov/govuk-developer-docs/blob/b5241f5c2202330ac8488fce3ce1fe8c681bb472/app/repo.rb#L145-L146
MuriloDalRi
approved these changes
Oct 23, 2024
AgaDufrat
reviewed
Oct 23, 2024
| @@ -96,7 +96,7 @@ def govuk_json | |||
| end | |||
|
|
|||
| def govuk_team_repos(team_channel) | |||
| @govuk_data.select { |repos| repos["team"] == team_channel }.map { |repo| repo["app_name"] } | |||
| @govuk_data.select { |repos| repos["alerts_team"] == team_channel }.map { |repo| repo["app_name"] } | |||
| rescue StandardError => e | |||
| puts "Error fetching govuk team repos (#{team_channel}): #{e.message}" | |||
| [] | |||
There was a problem hiding this comment.
Do we need to update the is_govuk_team? for consistency? 🤔
There was a problem hiding this comment.
Yes, I think we do. I've updated that in #571.
AgaDufrat
reviewed
Oct 23, 2024
| @@ -11,11 +11,11 @@ | |||
| let(:uri) { URI("https://docs.publishing.service.gov.uk/repos.json") } | |||
|
|
|||
| let(:repos) do | |||
There was a problem hiding this comment.
It would be good to have some tests for a scenario when "team" is not the same as "alerts_team".
There was a problem hiding this comment.
I don't think we need any tests here, since govuk-developer-docs will always return a value for alerts_team.
brucebolt
added a commit
that referenced
this pull request
Oct 23, 2024
In #570, we added the ability to post alerts to a different Slack channel to the main team. Changing the hash key in this method was missed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, PR review reinders are sent to the Slack channel of the team who own the application.
Some teams may wish to have automated alerting sent to a different channel. Therefore updating to use the
alerts_teamvalue instead of theteamvalue.By default,
govuk-developer-docsfalls back to theteamvalue where no other value is specified.Trello card