Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also check security workflow for scans #552

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Also check security workflow for scans #552

merged 1 commit into from
Jul 9, 2024

Conversation

MuriloDalRi
Copy link
Contributor

Some repos might have the required scans in a security.yml workflow.

https://trello.com/c/lIXK5ac5/3573-make-ci-check-also-consider-securityyml-2

AgaDufrat
AgaDufrat reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@AgaDufrat AgaDufrat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but with the logic getting more and more complex we should add some tests. Would you mind doing that?
Ideally this logic should be in it's own class, which may make it easier to add unit tests.

@MuriloDalRi
Also check security workflow for scans
b8eca4e 
Some repos might have the required scans in a security.yml workflow.
@MuriloDalRi MuriloDalRi merged commit 913aab8 into main Jul 9, 2024
9 checks passed
@MuriloDalRi MuriloDalRi deleted the sec-yml branch July 9, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgaDufrat AgaDufrat AgaDufrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MuriloDalRi @AgaDufrat