Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content-modelling/550 Return publishing app for host Editions #2876

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Harriethw
Copy link
Contributor

@Harriethw Harriethw commented Sep 20, 2024

This returns the publishing app name for all host editions (Editions with Embedded content in them)

In this previous Whitehal PR we send publish intents for host Documents of embedded content, but we hardcoded the publishing app to Whitehall - we need to see the correct publishing app for all host editions in order to send these intents.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.

Follow these steps if you are doing a Rails upgrade.

This returns the publishing app name for all host
editions (Editions with Embedded content in them)

In this previous Whitehal PR [1] we send publish
intents for host Documents of embedded content,
but we hardcoded the publishing app to Whitehall -
we need to see the correct publishing app for all
host editions in order to send these intents.

[1] alphagov/whitehall#9447
@Harriethw Harriethw force-pushed the content-modelling/550-host-document-publishing-app branch from 4b9086b to 12341f0 Compare September 20, 2024 09:35
@Harriethw Harriethw merged commit 81fcd00 into main Sep 20, 2024
12 checks passed
@Harriethw Harriethw deleted the content-modelling/550-host-document-publishing-app branch September 20, 2024 09:57
Harriethw added a commit to alphagov/whitehall that referenced this pull request Sep 20, 2024
Now that this PR is merged [1] we should be able to retrieve the name of
the publishing app for Host Content. We will shortly use this when
creating Publish Intents to remove the cache when updating Host Documents.

[1] alphagov/publishing-api#2876
Harriethw added a commit to alphagov/whitehall that referenced this pull request Sep 20, 2024
We want to remove the cache Host Content that is not published by Whitehall,
as embedded content can be used across all Publishing apps.

[1] alphagov/publishing-api#2876
Harriethw added a commit to alphagov/whitehall that referenced this pull request Sep 20, 2024
Now that this PR is merged [1] we should be able to retrieve the name of
the publishing app for Host Content. We will shortly use this when
creating Publish Intents to remove the cache when updating Host Documents.

[1] alphagov/publishing-api#2876
Harriethw added a commit to alphagov/whitehall that referenced this pull request Sep 20, 2024
We want to remove the cache Host Content that is not published by Whitehall,
as embedded content can be used across all Publishing apps.

[1] alphagov/publishing-api#2876
Harriethw added a commit to alphagov/whitehall that referenced this pull request Sep 20, 2024
We want to remove the cache Host Content that is not published by Whitehall,
as embedded content can be used across all Publishing apps.

[1] alphagov/publishing-api#2876
Harriethw added a commit to alphagov/whitehall that referenced this pull request Sep 20, 2024
Now that this PR is merged [1] we should be able to retrieve the name of
the publishing app for Host Content. We will shortly use this when
creating Publish Intents to remove the cache when updating Host Documents.

[1] alphagov/publishing-api#2876
Harriethw added a commit to alphagov/whitehall that referenced this pull request Sep 20, 2024
We want to remove the cache Host Content that is not published by Whitehall,
as embedded content can be used across all Publishing apps.

[1] alphagov/publishing-api#2876
Harriethw added a commit to alphagov/gds-api-adapters that referenced this pull request Sep 20, 2024
This adds the field added in Publishing API here
alphagov/publishing-api#2876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants