PP-5366 - use inputmode on numeric fields #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbishop1
reviewed
Jun 25, 2019
jonheslop
force-pushed
the
PP-5366-update-numeric-fields
branch
from
d7cc402 to
59862b1
Compare
|
The pattern is
|
|
But does using |
The Design System team have done some accessibility testing on `input type="number"` and deemed them problematic. They have suggested using `input type="text" inputmode="numeric" pattern="[0-9]*"` instead as documented here alphagov/govuk-frontend#1449
jonheslop
force-pushed
the
PP-5366-update-numeric-fields
branch
from
59862b1 to
d95ab44
Compare
jonheslop
changed the title
alexbishop1
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Design System team have done some accessibility testing on
input type="number"and deemed them problematic. They have suggested usinginput type="text" inputmode="numeric" pattern="[0-9]*"instead as documented here alphagov/govuk-frontend#1449
But because this is a currency input and we need to accept decimals points we’re going with
input type="text" inputmode="numeric"in this case