PP 11288 improve validation on prefilled and non-prefilled payment links #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Initial code change is for validation of zero amount value supplied via prefilled and non-prefilled payment links.
- creating new error message labels and updating code references, for both prefilled and non-prefilled payment journeys
- package-lock.json update
- Updated the session data handling logic which determined a prefilled journey and used the paymentLinkSession attribute - Added test for the amount page for non-prefilled payment link scenario. - Added test for the confirmation page prefilled payment link scenario.
- Added Cypress Tests
- Added updated zero amount check
- interim welsh translation and linting
iqbalgds
reviewed
Nov 17, 2023
| @@ -18,7 +18,8 @@ | |||
| "title": "Digwyddodd gwall:", | |||
| "default": "Mae’n ddrwg gennym, ond ni allwn brosesu eich cais. Rhowch gynnig arall arni wedyn.", | |||
| "internal": "Mae problem gyda’r cyfleuster taliadau. Rhowch gynnig arall arni wedyn", | |||
| "contactService": "Mae problem gyda’r cyfleuster taliadau. Rhowch gynnig arall arni wedyn" | |||
| "contactService": "Mae problem gyda’r cyfleuster taliadau. Rhowch gynnig arall arni wedyn", | |||
There was a problem hiding this comment.
We should wait until we have the official translations.
iqbalgds
reviewed
Nov 17, 2023
| @@ -55,6 +55,29 @@ describe('Payment link visited with amount and reference provided as query param | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| it('should show error page when confirmation page has a £0 amount and the "Continue to payment" button is clicked', () => { | |||
There was a problem hiding this comment.
Need to check this with John's story.
I don't think you can get to this page when there is a 0 amount.
Throws an exception and the user will see an error page.
There was a problem hiding this comment.
As discussed over slack, will wait for UCD feedback etc
iqbalgds
requested changes
Nov 17, 2023
|
@olatomgds - Can you please squash the commits |
- initial commit for bypassing confirmation page
|
This PR has been superceded by #2636, hence will be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For prefilled payment links, the service can set a reference and also an amount for payment links when sending the link to users.
The change involves the following:
When the user has to enter the amount manually for a non-prefilled payment link user journey, an appropriate error page with the agreed error message is displayed, if the amount is £0
Validate the amount on the confirm page and display an appropriate error page with the agreed error message, if the amount is £0
Some further changes is required in the pay-products API, but this is done as a separate PR against the pay-products repository