Bump GOV.UK Frontend to v2.2.0 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the changes the new Frontend version introduces[1] is the lack of the full size select boxes by default. In order to keep up with the design as much as possible, we're adding the extra class to force these expand as they use to. [1]: alphagov/govuk-frontend#960
This reverts commit 6a007a7. The issue in question has been beautifully handled by the Design System Team[1] and no longer needs to exist in our codebase. Going back to the standard GOV.UK Frontend for consistency and easier upgrades. [1]: alphagov/govuk-frontend#982
AP-Hunt
force-pushed
the
bump-frontend-2.2.0
branch
from
d5fe09f to
a152640
Compare
|
Rebased this on top of master |
|
|
😖D'oh, thanks. I'll get 2.2.0 merged, then raise a new PR for 2.10.0. It may well make a bunch of Dependobot's PRs irrelevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The Design System team has released a lot of fixes and are now
providing version 2.2.0. We're few versions behind and the fixes
include some of the identified by us previously.
One of the changes the new Frontend version introduces is the lack of
the full size select boxes by default.
In order to keep up with the design as much as possible, we're adding
the extra class to force these expand as they use to.
This also reverts commit 6a007a7.
The issue in question has been beautifully handled (alphagov/govuk-frontend#982) by the Design System
Team and no longer needs to exist in our codebase.
Going back to the standard GOV.UK Frontend for consistency and easier
upgrades.
As a bonus, we're upgrading dependencies in order to prevent
vulnerabilities.
How to review
already raised