Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line about the data sharing and financial agreement to the checklist #2327

Merged
merged 4 commits into from
Sep 26, 2018

Conversation

quis
Copy link
Member

@quis quis commented Sep 25, 2018

Before After
image image

2/3 of our incomplete requests to go live are incomplete because the Data Sharing and Financial Agreement isn’t signed.

We reckon we can be pushier about this by saying it’s ‘incomplete’ where we know the agreement is signed.

Where the agreement is signed we should confirm this, rather than make the line disappear. This is so it makes more sense to someone who sees it as ‘incomplete’, signs it, then comes back to the page.

If we don’t know whether or not the agreement is signed we should wait until someone has got in touch with us by requesting to go live to figure it out. So that’s why we’re not showing that line at all.


Needs @karlchillmaid’s input on the content before merging.

This duplicates how the task list pattern is coded in the GOV.UK
Prototype kit[1]. It adds ARIA attributes and the use of a
semantically-meaningful element (`<strong>`) to give more information to
screen reader users.

1. https://govuk-prototype-kit.herokuapp.com/docs/templates/task-list
2/3 of our incomplete requests to go live are incomplete because the
Data Sharing and Financial Agreement isn’t signed.

We reckon we can be pushier about this by saying it’s ‘incomplete’ where
we know the agreement is signed.

Where the agreement is signed we should confirm this, rather than make
the line disappear. This is so it makes more sense to someone who sees
it as ‘incomplete’, signs it, then comes back to the page.

If we don’t know whether or not the agreement is signed we should wait
until someone has got in touch with us by requesting to go live to
figure it out. So that’s why we’re not showing that line at all.
We think that the next page explains the nuance around service vs
organisation sufficiently well.
@quis
Copy link
Member Author

quis commented Sep 26, 2018

Make wording around agreement more straightforward

image

We think that the next page explains the nuance around service vs organisation sufficiently well:

image

@quis
Copy link
Member Author

quis commented Sep 26, 2018

Remove ‘Download the’ call to action

Users come to this page from various places, including the new 'Sign the…' link on the request to go live page.

Of these users:

  • some won't have signed it
  • some will have signed it
  • some will see that it's complete and wonder why, as they haven’t actually done anything

So it’s more appropriate for the title of this page to be descriptive,
rather than an action.

Before After
image image

Copy link
Contributor

@karlchillmaid karlchillmaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good

Users come to this page from various places, including the new 'Sign
the…' link on the request to go live page.

Of these users:
- some won't have signed it
- some will have signed it
- some will see that it's complete and wonder why, as they haven’t
  actually done anything

So it’s more appropriate for the title of this page to be descriptive,
rather than an action.
@quis quis force-pushed the add-mou-to-checklist branch from d1c3b8d to c251c13 Compare September 26, 2018 15:16
@quis quis merged commit 6de0374 into master Sep 26, 2018
@quis quis deleted the add-mou-to-checklist branch September 26, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants