Add a service setting to switch basic view on and off #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servingUpAces
approved these changes
Jul 10, 2018
Often we show/hide these rows based on what permissions a service has. This commits refactors that check into a reusable macro, rather than having to write the same `if` statements all the time.
This commit adds: - a row to the settings page… - …which links to a page explaining what basic view is The new row (and link) will only appear for services who already have the feature switched on. This is because we are not launching the feature yet, so it shouldn’t be available to just anyone.
This commit adds radio buttons to the ‘basic view’ page. This will let users choose whether basic view is on or off for their service. As before, this page will only be linked to if a service already has basic view, so this commit does not launch the new feature.
Since platform admins can use the new settings page, this commit: - links to that page - removes the platform-admin-only endpoint that switches basic view on and off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new row and page will only appear for services who already have the feature switched on. This is because we are not launching the feature yet, so it shouldn’t be accessible to just anyone.
N.B. a lot of the volume of changes in the PR are from ba39d00, which is just a refactoring commit. May be best reviewed commit-by-commit.