Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a checklist to the request to go live page #1909

Merged
merged 3 commits into from
Mar 9, 2018

Conversation

quis
Copy link
Member

@quis quis commented Feb 27, 2018

We reckon that by making this list respond to what the user has done that it will be more effective than a static list.

We don‘t want to block anyone from making the request. The request to go live is essentially the end of our conversion funnel. So introducing a roadblock feels like a dangerous thing to do. These changes represent more of a speedbump.

Check for team members

One of the things that we want to check before a service goes live is that they have at least two team members with the manage service permission. Anyone who can make a request to go live has this permission, so that means one additional user is needed. This is what we can automatically communicate to the user.

Check for templates

We need users to have created some templates before they go live, so we can see what kind of messages they intend to send. This won’t catch users who only have ‘testing’ template(s) set up, but it will at least warn those who have none.

Check for reply to email address

We require that a user has a real reply-to email address before going live. We can partially automate this by at least telling users who haven’t done this.

This only applies for users that have email templates; we shouldn’t bother users who aren’t going to send emails about this.

Before

image

After

image


Addresses alphagov/notify-design-archive#4

quis added 3 commits February 27, 2018 15:17
One of the things that we want to check before a service goes live is
that they have at least two team members with the manage service
permission. Anyone who can make a request to go live has this
permission, so that means one additional user is needed. This is what we
can automatically communicate to the user.

Under the hood this makes use of the logic added in
#1891
We need users to have created some templates before they go live, so we
can see what kind of messages they intend to send.

We can do this automatically based on the work done in
#1892
We require that a user has a real reply-to email address before going
live. We can partially automate this by at least telling users who
haven’t done this.

This only applies for users that have email templates; we shouldn’t
bother users who aren’t going to send emails about this.
@quis quis merged commit 6e869bf into master Mar 9, 2018
@quis quis deleted the request-to-go-live-automation branch March 9, 2018 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants