Upgrade GOV.UK Template, Frontend Tookit, and Elements #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should make sure that the parts of the UI that we inherit from these
packages are kept up to date.
This commit:
- updates each dependency to the latest version
- makes patch (bug fixing) version bumps automatic because
- it makes less work for us
- we don’t get so far behind
- we should be able to trust dependencies that are coming from other
teams in this building
Full changes that this brings in:
GOV.UK Template
---
- Increase skiplink colour contrast ([GOV.UK Template PR #263](alphagov/govuk_template#263))
GOV.UK Elements
---
- Too many to show – see
alphagov/govuk_elements@v1.1.1...v3.0.2#diff-4ac32a78649ca5bdd8e0ba38b7006a1e
GOV.UK Frontend Toolkit
---
- Too many to show – see
alphagov/govuk_frontend_toolkit@v4.6.0...v5.2.0#diff-4ac32a78649ca5bdd8e0ba38b7006a1e
Previously the beta bar was orange, which we didn’t want. So we wrote some SASS to make it blue. Now that GOV.UK Frontend Toolkit makes it blue, we can remove this SASS. See alphagov/govuk_frontend_toolkit#370
The external link icon, and associated mixin, were deprecated in alphagov/govuk_frontend_toolkit#293 This means we can’t and shouldn’t use them any more.
The visual appearance of radio and checkbox form inputs changed in GOV.UK Elements here: alphagov/govuk_elements#296 This was subsequently reimplemented with different markup and no Javascript here: alphagov/govuk_elements#406 This has meant making the following changes to our app: - changing the markup in our radio/checkbox macros to match the example markup given by GOV.UK Elements - removing the previous Javascript file because it’s no longer needed to make the radios appear visual selected - making the buttons on the scheduled job picker look like links, because the grey button style looked weird with the new radio buttons
The Elements CSS was making the `label` and `input` of disabled radio buttons `opacity: 0.5`. This was resulting in text that was: - too pale, especially where we were nesting 16px ‘hint’ text inside the label - waaaay too pale when inside a link inside the label This commit overrides elements to dim the disabled radio button by making it’s text colour grey, rather than making the whole thing semi-transparent.
Implements the class name changes detailed in: alphagov/govuk_elements#405
Not sure why we were doing this. But as part of the Elements upgrade our back buttons got bigger (because they weren’t constrained by the line in our `app.scss`) but any green submit buttons stayed smaller in height, so didn’t line up. This commit removes the override, so all buttons have the size that Elements intended.
GOV.UK Elements changed tables to be a larger font size here: alphagov/govuk_elements#185 This is good in principle (and a lot of our tables are 19px already). However, the ones that aren’t are still 16px because there’s a lot of info to fit on the page (eg when previewing someone’s CSV file).
leohemsted
approved these changes
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should make sure that the parts of the UI that we inherit from these packages are kept up to date.
This commit:
Full changes that this brings in:
GOV.UK Template
GOV.UK Elements
GOV.UK Frontend Toolkit
Major visual changes
Darker borders around text input elements
New radio and checkbox inputs