Fix #325 Focused, unvisited links are (extremely) low-contrast

[alex-ju]

This commit fixes #325, which is in essence a fix for PR #272 which was an attempt to fix #264.

If that sounds confusing enough, here is the short story:

• Now we have blue text on green buttons when focused on unvisited links.
• This PR is making use of a "less powerful" selector for improving contrast on links while not affecting buttons.

Buttons
Before:

After:

Tested with latest Chrome, Firefox on OSX and Windows and IE9, IE10, IE11 on Windows.

[edwardhorsford]

Is this issue about the blue text on buttons?

I'm not clear if things are fixed from the images - the button 'after' example still looks wrong. It also looks like focused links are now black - was that the intention?

[alex-ju]

@edwardhorsford sorry for the misleading screenshots. updated.

[edwardhorsford]

Thanks @alex-ju

Is there a reason focused regular links are now black rather than blue? I don't have a huge opinion on it, but it's a new change (over and above fixing the original bug as I saw it).

[alex-ju]

@edwardhorsford you're right, the regular links are not affected by this change; they will only be slightly darker when focused, as before. but the change is still relevant for focused unvisited links

[NickColley]

Just ran into this, can we get this in? @edwardhorsford any objections?

[edwardhorsford]

@NickColley I forget what this PR is about. Skimming it, it sounds like the PR was changing things outside of buttons - is that still the case?

[36degrees]

I think this will mean that visited links, when focussed, will be dark blue rather than purple. How much of an issue is that?

The alternative, I think, would be to make the button more defensive – it would need to set a white text colour against the :link:focus and :visited:focus pseudo selectors?

[alex-ju]

The intention was to make the only the unvisited links darker. This PR doesn't fix that, so I'll close for now with the heads up that the problem is still there.