Revert "Merge pull request #849 from alphagov/prevent-double-click-on… #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-buttons" This reverts commit 19cc9d0, reversing changes made to 9f259ca. Previously we changed the button component to automatically prevent double click for submit-type buttons. This caused an unexpected testing issue in a consuming app (Content Publisher) in the context of a modal, where multiple buttons are clicked in succession without a page reload. This reverts the change to automatically prevent double click, pending an iteration to the logic in govuk-frontend to scope the prevention to the same button.
benthorner
force-pushed
the
revert-prevent-double-click
branch
from
5fe8432 to
d99cd82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-buttons"
https://trello.com/c/JLkfkNxQ/815-fix-the-double-click-so-actions-are-only-carried-out-once
This reverts commit 19cc9d0, reversing
changes made to 9f259ca.
Previously we changed the button component to automatically prevent
double click for submit-type buttons. This caused an unexpected testing
issue in a consuming app (Content Publisher) in the context of a modal,
where multiple buttons are clicked in succession without a page reload.
This reverts the change to automatically prevent double click, pending
an iteration to the logic in govuk-frontend to scope the prevention to
the same button.